[BUG][FIXED] Remove Update Message Box (points to NL site)

Simon · January 27, 2025, 02:26:20 AM

Extract to new directory.
Copy settings/ from an existing NL into CE. (Should I attach a copy?)
Run NeoLemmixCE.exe.

Observed: Main menu appears, and a message box appears: "A NeoLemmix update, V12.14.0, is available. Do you want to download it?"

Expected instead: Main menu appears. No such update box appears. Two reasons: CE 1.0 is newer than NL 12.14. And CE isn't distributed via the NL website.

(After this, CE runs well. Ah, this is wonderful, the zoom bug is fixed and it has the decreed 12.14 physics.)

-- Simon

WillLem · January 27, 2025, 03:48:01 AM

Quote from: Simon on January 27, 2025, 02:26:20 AMCopy settings/ from an existing NL into CE. (Should I attach a copy?)

Yes, I suppose users are going to want to copy their settings across, if not from NeoLemmix then from version to version in CE. I'll need to re-think the way this is handled. That's for another day.

Quote from: Simon on January 27, 2025, 02:26:20 AMObserved: Main menu appears, and a message box appears: "A NeoLemmix update, V12.14.0, is available. Do you want to download it?"

Yeah, it's likely seeing the "1.0" and determining, correctly, that this is older than "12.14".

We don't want to completely strip away the online stuff, because the Style Manager relies on it (@namida, are we still OK to rely on styles updates via the NeoLemmix website for CE?). However, this specific part of it will need to be updated CE-side for sure. I'll get that fixed for the proper release.

Quote from: Simon on January 27, 2025, 02:26:20 AM(After this, CE runs well. Ah, this is wonderful, the zoom bug is fixed and it has the decreed 12.14 physics.)

namida · January 28, 2025, 07:40:18 AM

Quote from: WillLem on January 27, 2025, 03:48:01 AM(@namida, are we still OK to rely on styles updates via the NeoLemmix website for CE?)

Yes, CE is more than welcome to use those downloads.

If something non-Lemmings related was mass downloading them I might have to consider whether access needs to be controlled somehow, but I have no problem with NL forks making use of it - that's really no different to just using them in NL itself as far as anything I need to care about goes. (And just in case I need to say it - it's also no problem at all if anyone wanted to integrate style downloading into a fork / custom NL editor, either.)

WillLem · January 28, 2025, 01:27:44 PM

This bug is fixed in commit c8e91a48.

For now, I've simply commented-out the part of the update check that analyzes the Player version as we'll likely want to re-implement that later specifically for CE, and so the update check now only returns style manager updates. Speaking of which...

Quote from: namida on January 28, 2025, 07:40:18 AM
Quote from: WillLem on January 27, 2025, 03:48:01 AM(@namida, are we still OK to rely on styles updates via the NeoLemmix website for CE?)
Yes, CE is more than welcome to use those downloads.

This is much appreciated, thanks

I've now grouped the "Style Manager" button with the online options and it's active state depends on whether or not online features are enabled. This is to make it extra clear that the style manager necessarily requires internet access: