Implement Rewind to Last Assignment Like NL?

[Simon]

kaywhyn, I'd still like to see you use the NL rewind-to-assignment in action, to see why you need it to rewind to two ticks before the effect is visible (instead of to the immediate tick before the effect is visible).

Since I made rewind-to-previous-assignment a year ago, I haven't used it a single time.

I don't know if I'd use rewind/advance to (the tick before an) an assignment of your choice in the replay tweaker. The tweaker doesn't have this feature yet. It looks natural to make this.

-- Simon

[kaywhyn]

Yes, I have not forgotten about this. Trying to think of the best way to go about this, especially as to avoid spoiling level solutions for you For now, let's just say that because I use this hotkey a lot that it has become natural for me during gameplay that I don't really use the "B" key to go back a frame even though pressing the rewind to last assignment hotkey does the same thing once the skill is assigned. Similarly, I use mouse clicks to advance a frame instead of the "N" key. I also find it very useful when I need to undo several skill assignments, even if it might be faster to just hold down the rewind hotkey or restart completely. I don't know, I'm one of those Lemmings/Lix players who generally doesn't like bringing up any pop-up windows/menus during gameplay, hence why I don't like using the replay tweaker even if it's likely the most efficient out of the "going back" hotkeys I use. I find menus during gameplay "intrusive" for some reason.

However, as "actions speak louder than words," I'll definitely get video footage for you of me using this feature. Thinking about it, unless you're ok with them, honestly probably the best thing for me to do is to just find one of my LP videos where I make extensive use of it, but again, the problem is spoilers. This will take some time, as I would have to watch through the many vids I have on my channel. Perhaps I can link a vid where there's only one level where the feature is used.

On another note, is it currently possible to customize the duration of the rewinds/time skips in Lix? If it is, then I'm not aware of how to do so. 

[Simon]

Lix has no customization of the rewinds.

What values would you choose?

-- Simon

[kaywhyn]

I use the 5-second rewind and 5-second forward NL hotkeys in addition to the 1-second rewind/forward, 10 second time skip, and rewind to last skill assignment. So really, the 5 seconds would be in addition to all the other rewind/forward Lix hotkeys, not replacing any of them

[WillLem]

In NL 12.5.5 12.12.5, this rewinds to two ticks before the assignment has happened
...
Years ago, NL had a bug where cutting the replay would cut one frame too late. Is this rewinding behavior an obsolete workaround for that bug? Or is there another reason?

...I'll see if I can get it to "one tick before assignment" in SLX - I'll investigate the bugfix and see if there's any reason it can't be done.

Finally got around to investigating this. Turns out that namida fixed the "-2" bug (in Commit 9c665ca), so NL (and indeed SLX) actually skips back only 1 frame prior to the previous assignment. Or, at least, it should.

When checking in the program itself, there is in fact an additional frame to step over before the assignment takes place.

I wonder if, prior to namida's fix, it was necessary to step over 2 frames. If so, then the current behaviour (having to step over 1 frame) is technically correct according to what's written in the code; i.e. the "Previous Assignment" hotkey which performs this skip asks NL to skip to "TargetFrame -1".

Is having to step over a single frame desirable? Or, is the expected behaviour that the next mouse click (i.e. to step forward 1 frame) should advance to the assignment frame? I wonder what the purpose of the extra frame is...?

It would be an easy fix, anyway (at least in NL/SLX); we'd simply ask it to skip to the "TargetFrame" itself.