[BUG] Selected button redrawn after backskip / Skill panel sound muted post-fix

[WillLem]

This double-bug is present in NeoLemmix as well (mods: by all means merge these topics).

The current fix for the first bug causes the second bug:

1) The 'selected' graphic is re-drawn over the pause button after subsequent backwards framesteps.

2) The skill panel sound (SFX_SKILLBUTTON / 'changeop') doesn't trigger.

[WillLem]

I think this should do it. This fix for bug 2 keeps the current fix for bug 1 intact:

Moved this...:

Code Select Expand


(in procedure TBaseSkillPanel.DrawHighlight)

if (fLastHighlitSkill <> spbNone) and (fLastHighlitSkill <> fHighlitSkill) then
    SoundManager.PlaySound(SFX_SKILLBUTTON);


...to here:

Code Select Expand


procedure TBaseSkillPanel.DrawButtonSelector(aButton: TSkillPanelButton; Highlight: Boolean);
begin
  if fGameWindow.IsHyperSpeed then Exit;
  if aButton = spbNone then Exit;
  if (aButton <= LAST_SKILL_BUTTON) then
  begin
    if (fLastHighlitSkill <> spbNone) and (fLastHighlitSkill <> fHighlitSkill) then      <--------------------------------------
    SoundManager.PlaySound(SFX_SKILLBUTTON);                                             <--------------------------------------
    if (fHighlitSkill = aButton) and Highlight then Exit;
    if (fHighlitSkill = spbNone) and not Highlight then Exit;
  end;
  if fButtonRects[aButton].Left <= 0 then Exit;

  RemoveHighlight(aButton);
  if Highlight then
    DrawHighlight(aButton);
end;


[namida]

Fixed the followup issue in commit d41be5d.