[✓][BUG][ED] Improvements to Talisman creation dialog UI

[Dullstar]

Under certain conditions (the exact details of which I haven't quite worked out yet) the talisman conditions for some levels cannot be edited.

I'll update with more details if I can figure out exactly what's going on, but I've attached the level I found this on.

The talisman "Optimization Lv. 2" was intended to have a limit of 3 bashers, but was saved with no requirements. I didn't notice this when the v9 update was first released (it was a contest level). When I noticed, I tried to fix it through the editor, assuming it was an oversight on my part, only to find that I couldn't change it. I thought that it might be due to its similarity to the talisman "Optimization Lv. 1" (limit 4 bashers), so I tried removing one of them, and the delete button didn't do anything.

Manually editing the talismans in a text editor worked as expected.

[namida]

Okay so - deleting is purely a matter of the list not being updated to reflect the deletion. It is in fact deleted, but the list doesn't get updated until something else causes the talisman list to be regenerated (such as editing a talisman - even if you cancel out of it).

I can't reproduce your issue with not being able to add the basher restriction.

[Dullstar]

I have not managed to isolate the trigger condition. It consistently happens to me on the one I uploaded, but it doesn't happen on the v10 version of the level, which is identical expect the talisman condition was updated in a text editor.

[namida]

Just to confirm: You are clicking "Add requirement" after selecting the condition / quantity, correct?

I spotted this as a potentially unintuitive aspect of the UI, but otherwise can't reproduce this, even using that exact level.

[Dullstar]

I assume I'm probably doing it correctly since it works on some levels, but when I have time I'll go ahead and record a video of it, since that should capture some details of what I'm doing to reproduce it that I might not think to include.

[Dullstar]

I haven't figured out what I was doing differently between the attempts to reproduce with v9 vs. v10 of the posted level, but...

It does seem to be related to unintuitive UI rather than a technical bug.

It's probably improvable, but I'm not sure what the best way to go about it would be.

[WillLem]

I'd like to take a look at improving the talisman creation UI as best as I can.

I've already made some improvements to the layout, and the skills listed in the requirements dropdown are now skillset-relevant (so, if the level only contains Bashers, Builders and Floaters, only these 3 skills will be listed in the dropdown, e.g. for limiting purposes).

It could probably be better though. For reference, here's how it looks in the NL Editor:

NL Editor Talisman Creator layout

The SLX Editor changes the layout to this:

SLX Editor Talisman Creator layout

The idea is that moving the requirement-creation controls and "Add New Requirement" button to above the requirements list is slightly more intuitive, but perhaps it could be improved even further? Here's one possibility:



The only issue is that I can't find a way to draw the right-angled line between the two controls. I sometimes use panels to achieve this sort of thing, but it's not ideal. Maybe the rewording of the button is enough?


EDIT: Managed to draw the lines but it didn't look quite right so opted to simply change the button caption. Implemented in SLX Editor commit 5512a05.