[✓][BUG][PL] Crash after quit: Press ESC twice during level preview

[Simon]

NL CE 1.0 in Wine 10.2 on Arch Linux.

• Start CE.
  
• Click in the main menu to go to a level preview.
  
• Wait for the fade-in to finish or not, it makes no difference.
  
• Press Esc to start the level preview's fade-out.
  
• Press Esc a second time, either before the level preview has finished fading out, or before the main menu has finished fading in.
  
• Watch the main menu fading out.
  
• See NL crash. Screenshot of the error box is in the attachment.
  

20-second video of the crash

Expected instead: No crash. I should get the same result regardless of how often I mash Esc during the fade-outs.

The program quits cleanly when I wait until the main menu has finished fading in before I press Esc the second time.

No data is lost. The program has already saved all user options and level results before it ever tries to quit from the main menu.

-- Simon

[WillLem]

Went to move this to the Community Edition bugs board, but of course it doesn't exist yet!

What was decided regarding this? Shall I just use the existing NL bugs board? It seems better for CE to have its own, but I'm happy to go with whatever's decided.


I can replicate the bug in Windows 11. I'll find a fix soon.

[WillLem]

Should be fixed in:

CE commit 3fad407
SLX commit 2ee282d

Used madExcept to help track down the cause, added a check to ensure valid pointer in the buggy method.

[Simon]

Thanks for looking at this so quickly! Happy to test it when you release binaries for the next time. I don't have a Delphi build toolchain here.

-- Simon