[BUG] Missing images

Started by WillLem, November 16, 2024, 07:31:48 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

WillLem

I've noticed a few posts have broken image links; the link itself is present, but the image isn't.

In some cases this could of course be expired links, but due to the sheer volume of missing images site-wide I wondered if the recent SMF update might be causing this issue.

Here's an example topic where many of the images are now missing.

namida

This should only affect posts that originated on the previous (LemmingsForums.com) website. The way these were imported was always pretty kludgy (necessary due to lack of access to the database or an up-to-date backup thereof), and resulted in that they appeared fine when viewed but got pretty awkward if edited / quoted; the SMF 2.1 update does seem to have broken them a bit further.

If we end up identifying a significant number of posts (not just two or three that would be easier to just fix manually) that are affected in a way that interferes with reading them (not just a stray HTML tag or two being visible, or having to click a link instead of an image being embedded), I'll look at whether I can put together some automated fix. Otherwise, I don't think it really matters that much.
My projects
2D Lemmings: NeoLemmix (engine) | Lemmings Plus Series (level packs) | Doomsday Lemmings (level pack)
3D Lemmings: Loap (engine) | L3DEdit (level / graphics editor) | L3DUtils (replay / etc utility) | Lemmings Plus 3D (level pack)
Non-Lemmings: Commander Keen: Galaxy Reimagined (a Commander Keen fangame)

WillLem

Quote from: namida on November 17, 2024, 01:17:48 AMa significant number of posts

Almost every post on this page has a missing image. Due to the nature of the topic (Count to 1000), the images are often the entire content of each post.

If you want to grant me mod privs for a day or two I'd be happy to have a look at that particular topic myself, see if I can get the embeds to work again by editing the posts manually. If I can get it to work for a few of them, it might be worth writing a script to sort the rest out.

For other topics, I agree it's probably not worth bothering with if they haven't been replied to in a while.

namida

You could, but it would literally be a matter of editing every single post one-by-one to fix them. And you'd need to convert any other HTML back to BBCode while you're at it too. I would very much question if it's worth it for a topic that's just "count to 1000", especially if the links are still there so the images can still be found. If the thought of spending several hours doing tedious edits like that doesn't put you off, then sure, I'm comfortable with letting you do that.
My projects
2D Lemmings: NeoLemmix (engine) | Lemmings Plus Series (level packs) | Doomsday Lemmings (level pack)
3D Lemmings: Loap (engine) | L3DEdit (level / graphics editor) | L3DUtils (replay / etc utility) | Lemmings Plus 3D (level pack)
Non-Lemmings: Commander Keen: Galaxy Reimagined (a Commander Keen fangame)

WillLem

Quote from: namida on November 17, 2024, 04:54:15 AMYou could, but it would literally be a matter of editing every single post one-by-one to fix them ... If the thought of spending several hours doing tedious edits like that doesn't put you off, then sure, I'm comfortable with letting you do that.

I'd probably do it a page at a time every now and again rather than all in one go. But yeah, point taken, it's probably not worth it.

I was more thinking: is there a solution which could fix links like this site-wide? If not, never mind.