SMF 2.1 Upgrade (upgrade is now live)

[namida]

Thanks for looking into the performance!

The forum has custom code, looks like you've all reeled it through the update to 2.1.

-- Simon

A lot of it was from add-ons, although those needed a few tweaks to be 2.1.4 compatible. The few minor changes I could see from looking through Staff Discussion, I reimplemented.

[kaywhyn]

Hmm, Strato sent me a PM this morning  (10AM my time zone, PST) and the current Forums software version doesn't seem to respect user settings like before. Before the upgrade, I have had notifications of a PM by email and a pop-up on the Forums enabled. They still are enabled, meaning I haven't changed those settings, but yea, I never got an email notifying me of a PM or any pop-up on the Forums telling me I got a PM. As a matter of fact, I didn't realize I got a PM until I noticed the 1 notification on the "my messages" at the top of the home page and about 13 hours after it was sent to me. The 1 is pretty small and barely noticeable as well, though that's probably nothing a bigger browser zoom setting can't fix.

edit: Checked Gmail's spam inbox and nope, no PM emails in there, as it should be, since I have a filter saying to not mark LF emails as spam from several years ago anyway

edit 2: One setting I did change was ticking the box for "when i receive a reply to a personal message" and then clicking "save." Maybe this will fix not getting an email when other members PM me. Though, I sent myself a PM and got a notification email after enabling the setting, so yea, perhaps this has been sorted out now. Let's see!

[Silken Healer]

Reporting an error with the new upgrade, since the upgrade loads of stuff is broken in: https://www.lemmingsforums.net/index.php?topic=1331.0.

[namida]

Reporting an error with the new upgrade, since the upgrade loads of stuff is broken in: https://www.lemmingsforums.net/index.php?topic=1331.0.

The broken posts pre-date the move to lemmingsforums.net (specifically, ones imported from lemmingsforums.com); they were always a bit hacky in the first place. I'll see what (if anything) can reasonably be done about this.

[Silken Healer]

I might be mistaken, but I am fairly certain I remember seeing the post being non-broken in that thread recently before the upgrade.

[namida]

I might be mistaken, but I am fairly certain I remember seeing the post being non-broken in that thread recently before the upgrade.

I didn't say they were always broken; I said they were always hacky (ie: not really done properly, just with an "anything that works" kind of approach). In particular, the raw message data for them in the database contained a pure HTML rip from the old site, instead of proper BBcode etc. This was necessary due to being unable to access a database backup from .com at the time.

Something in the SMF 2.1 upgrade must've not played nicely with this (whereas SMF 2.0 was fine with it - either because of a difference between them, or because it was specifically the upgrade process that caused issues).

[namida]

I've had to disable IPv6 access to the site, as it's been reported non-working and I don't have any way to test it. (This should be unnoticable during general use of the site, as your browser should just fall back to IPv4 anyway.)

[namida]

In addition to the changes Simon made the other day, I fixed up a couple more things that weren't quite right with the Lemmings Dark theme.

Code Select Expand

In particular, text in [code] tags should now be readable without having to highlight it.
I also applied Simon's font size fix to the other two themes (as he had only put it in Lemmings Dark).

[Silken Healer]

(Reporting an issue with the new upgrade)

On the default theme the "statistics" section of a user's profile has some poor contrast with the text colour compared to the background colour. The text that says "Posting activity by Time,"  "Most popular Boards by Activity" and "Posting activity by Time" is hard to read, and the times underneath the bars are completley illegible.

Screenshot on the latest version of Firefox:

[Silken Healer]

(Reporting an issue with the new upgrade)

Was the issue regarding the recent posts (https://www.lemmingsforums.net/index.php?topic=6156.0) ever resolved? I just noticed, on the deafult theme, the recent posts shows lots of posts, and does not have horizontal rules. However, on all the other themes, the post history does not go as far back, and it has horizontal rules.

Edit: Important note: I didn't want to give a set in stone figure in case the amount of posts is based on some other factor as part of the bug, such as date posted, but note it is not just as simple as 25 on the non-deafult themes and 40 on the old one. Currently, it's 15 on the non-deafult ones and ~52 on the deafult theme.

[namida]

I never specifically looked into it, but after getting that mod working (with decent performance) with SMF 2.1, I do now know why it likely happened: There's a limit on how many posts it looks at from the database in order to generate that list. So, it'll grab the 1000* most recent posts, and go through them one-by-one until it's got posts from 25* different topics that the current user can see (eg. it won't include posts on Staff Discussion when a regular user views the list, only when a mod/admin does). However, if the first 1000 posts all come from the same 20 topics, it doesn't fetch more posts (likely because this isn't a super common case and the lost functionality is far from critical, so they didn't bother), it just makes the list shorter.

* 1000 and 25 are just example numbers, not necesserially the actual values

Recent post count shouldn't vary between themes, but maybe something's wrong on some of them - I'll take a closer look sometime, although it probably won't be until next week.