[BUG] Builder shadow doesn't ignore disabled traps [FIXED]

[Crane]

If you try to build near a trap that has been disabled with a Disarmer, the shadow, if it passes through the trigger area, implies the lemming will get eaten by the trap even though they will build through it without incident.

Find attached pictures of the level "Cloning Vats" from Lemmings Cranium showing this in practice... first the laser trap is disabled, and then the truncated builder shadow is shown in the next two images... the first from the Disarmer just as they finish, and the second from another lemming approaching the disabled trap.

Other skill shadows have not been tested, but I imagine the bug to be common to all projections that approach traps.

[kaywhyn]

Yes, it's the same with other skill shadows too. I first noticed this with the miner on a Lemmings Open Air level after disarming a trap and I found the truncated skill shadow quite odd. I meant to report this but apparently I never got around to doing so Thanks for doing so

[namida]

New suggestions or bug reports are no longer being taken for NeoLemmix, unless they're particularly critical (or related to WIP features, or newly introduced in an experimental release). Since this has likely been the case for as long as shadows have existed and no one has raised it until now, I don't think this one qualifies.

[WillLem]

This topic, basically.

Admin: please merge that one here. Thanks

[Simon]

Done!

-- Simon

[WillLem]

Upon further investigation, this bug appears to only affect lems that are Disarmers - other lems' skill shadows are displayed as expected.

Best guess so far: Disarmers are still reading the gadget as a trap. So the game, at least during simulation, wants the lem to stop Building/Mining/Bashing/whatever and begin Disarming whenever it sees the trigger area.

[WillLem]

OK, this ended up being quite an easy fix, and my guess was correct! SimulateLem just needed to take disarmed traps into account when deciding whether or not to transition a simulated Disarmer to the "fixing" action.

Fixed in Commit 56f1ed30d.