[SUG] Group sign/preview should stop at lowest/highest group instead of cycling

[WillLem]

From a conversation on Discord:

On (menu) screen, when using up and down arrows do not continue but stop at highest or lowest setting... like old neolemmix. Sometimes it's hard to know if you're on the lowest setting because of a strange name.
...
Right now you tap the up arrow but when you get to the highest level it resets to the lowest.
if you press the up arrow, you scroll through tricky, taxing, mayhem... then it starts over.
...
Old neo used to stop at the highest option. Some level packs are hard to tell if you're at the last option.

[WillLem]

I agree that the group sign should stop at the lowest/highest group in the pack rather than cycling infinitely.

Jeremy is correct in that it's not always clear from a pack author's description/naming system whether the current group is the highest or lowest, and having the up/down arrows stop at the highest/lowest groups respectively would help to make this more clear to players.

It's an easy enough fix: I've added a method to check whether the current group is the lowest or highest, and return relevant flags. It works, and can also be used for browsing through the pack from the level preview screen as well.

I'm fairly convinced this is right way to go for at least the group sign (main menu), what do people think about the arrow keys stopping at the lowest/highest groups in the level preview screen as well?

[jkapp76]

Is this the level-preview screen you're talking about?
If so, I think it would be cool to cycle through levels here. And anyone who doesn't want to cycle levels can just keep their fingers off the buttons, right?

Seems good to me... if I understand it right.

[WillLem]

If so, I think it would be cool to cycle through levels here. And anyone who doesn't want to cycle levels can just keep their fingers off the buttons, right?

Yes, this screen is correct. Current behaviour is to cycle back around.

OK, we'll leave it as it is for the preview screen. The "stop at lowest/highest group" behaviour has only been implemented for the Main Menu group sign.

I'll keep the topic open in case anyone thinks the behaviour should be implemented for the preview screen as well - I'm about 50/50 on it personally, and we can always revisit this at some point in the future. - due to lack of interest in this particular suggestion, the topic is now closed.

Implemented in Commit 3b805a83e