[BUG][PLAYER] Permanent skill remover doesn't stop in-progress actions

[namida]

For example - place a permanent skill remover half way up a wall, and assign a climber to climb up it. The lemming will encounter it, lose his climber skill, but continue climbing this wall (when he falls off it, he won't be able to climb the next one).

Similar cases apply to all other skills (except Disarmer which this situation can't really occur for).

This was a (major) oversight, rather than "I implemented it but it isn't working properly".

[namida]

Fixed in commit fa58196. I have a feeling that some variation of a bug I encountered with the Climber and Slider may persist, though. EDIT: Commit 5df4e89 should sort that out.

I still need to verify that fall distances are measured correctly in the transitions that occur due to this.

Climber, Slider: Will fall down facing away from the wall. My reasoning - the only situation in which a climber or slider faces towards the wall after it, is when they reach the top/bottom (as applicable) completely uninterrupted.
Floater, Glider: Immediately become faller.
Swimmer: Immediately drowns.
Disarmer: No special handling, as this situation should not be able to occur anyway.

[namida]

Closing this topic as the core bug itself is fixed.

Splitting it into two more new topics:
- Discussion re: facing direction for Climbers and Sliders who get interrupted by a remover
- Bug report re: fall distances (which is now confirmed that yes, there are bugs)