[SUGGESTION][PLAYER] Manually pressing Save Replay should give save dialog

[Dullstar]

I'm guessing this probably didn't get a lot of attention during the testing of the release candidates, because many (most?) of us have automatic saving on, but I recently wanted to save a best-attempt replay of a level I wasn't able to solve, and that has to be done by saving manually. So, on the post-view screen, I clicked the save replay button.

Expected: Preferably a file dialog, but at least some sort of feedback indicating that the replay was, in fact, saved
Actual: Replay saved silently, with absolutely no feedback. At first I thought my click didn't register until I tried it again and it still appeared to do nothing

I think a file save dialog is the best option here, because if I'm choosing to save a replay manually, there's probably something special about it that would make it desirable to explicitly choose a filename rather than relying on the automatically generated filename.

[namida]

It's not the most noticable, but the clickable texts do turn a different color when clicked vs when hovered, so there is some feedback. However, I do agree. In-game is debatable - I probably wouldn't want to be interrupted with a filename popup if I try to manually save a replay - but on the postview screen, the otherwise-automatic name could simply become the default, and I don't believe it would be too intrusive here.

[WillLem]

I think a file save dialog is the best option here, because if I'm choosing to save a replay manually, there's probably something special about it that would make it desirable to explicitly choose a filename rather than relying on the automatically generated filename.

+1 for this

[Strato Incendus]

+1 from my side as well. Opening the save dialog would also make it easier to tell if you have already manually saved a replay or not. Otherwise, you might press U several times during the level, just to be on the safe side, and potentialy create a bunch of redundant replays that are hard to distinguish in hindsight.

[namida]

In commit f1ecaca, I have implemented a crude solution which simply turns the user's "auto name replays" setting off when clicking this button. This solution will be in place for all V12.10.X versions (from 12.10.1 onwards), and possibly V12.11.X.

I'll come back to this matter properly as part of V12.11.X or V12.12.X development.

[WillLem]

Using this button opens a "Save As" dialog, as originally suggested. Just wondered why you've described this as a "crude solution", it seems to work just fine!

[namida]

The way it is implemented behind-the-scenes is very kludgy, even though it seems fine to the end user.

[namida]

Nice, and user-configurable, implementation of this is in place for V12.11, implemented in commit 00cca5c. Will post more detail in another topic here that it pertains to a bit better.