[BUG][PLAYER] Slider->Shimmier transition issues

[Strato Incendus]

Yes, the Grenader seems much better now! I think it should be perfectly fine to accept it the way it is now into the final version!



However, I noticed a weird thing about the Slider:
It seems like it's no longer possible to slide down at the end of a Builder staircase and then transition into a Shimmier. Is this intended?

Since a Builder's staircase only consists of 1-pixel increases, its underside can be used by regular Shimmiers. Sliders can transition into Shimmiers at corners / edges.
So I don't see why it shouldn't be possible here? As a player, I would expect this transition to be possible, just like is has been so far. And we would lose a great interaction with Builders if it isn't!

For transparency, on one of my levels, it's a special case, because a Slider has to transition into a Shimmier on the underside of a staircase as it is being built. But I don't see why this should make a difference.

EDIT: Seems like it isn't possible on angled slopes of regular terrain either, if the transition is directly to an angular slope. It only works if there are at least a couple of pixels of a vertical wall before that. I've attached a test level where you can try this out.

I think this is weird. It should be perfectly possible for the Slider to turn around and transition into a Shimmier even if the terrain stripe is just 1 pixel thick. Which doesn't work either (see the second attached level).

[namida]

The 1 pixel thick one: You can assign the shimmier, but it assigns in the wrong place - then reverts to a Slider, who can then be assigned another Shimmier, and this one works. So it appears the first Shimmier is being positioned one pixel too high.

The slope one: Well first, the example you attached is also 1px thick at the end, so that level itself is just another example of the 1-pixel case. However, I investigated this further and found that slopes are still a special case, because a 2px or 3px wall works fine with a Slider->Shimmier transition when the bottom is flat, but has issues when there's a slope. This too appears to ultimately stem from "shimmier is placed too high".

Finally, as a reminder: Please create dedicated topics to report bugs (or make suggestions, unless it's more just a vague "throwing ideas around" type thing). It's fine to mention them in the general thread, but it is very easy for them to get overlooked if they do not have their own topic.

[Strato Incendus]

Thanks a lot for moving this, namida! I didn't create a bug topic right away, because I wasn't sure it was one... It might just as well have been a behaviour that was removed intentionally, and I would have been the only one complaining about it because I like those types of Shimmier transitions.

But good to hear this will most likely be enabled again once the Shimmier is placed correctly after sliding.

[namida]

Both issues - which turned out to have a common cause - are fixed in commit c7b4481. The reason the bug didn't present itself visibly with the non-slope 2px / 3px walls is because while the lemming was off by 1px, it just saw this as "oh, I have to descend one pixel on the next frame" (whereas when there's a slope, that's on top of this pixel, which made it 2 pixels and thus reverted to slider).