Implemented: Search list should show all results

[Forestidia86]

Edit Simon: This is now github issue #429: Search dialog, implement scrollbar and up/down nav.



At the moment the search list only shows 18 of the matching results.
Imho all matching results should be shown though.

[Simon]

The search dialog also has a fake scrollbar! And it forgets all the indexed levels after you close it.

Yeah, the search dialog needs more work. geoo has already complained that it doesn't support selection up/down by keyboard. With level tags that we want to filter via search, the search dialog becomes even more important.

-- Simon

[Forestidia86]

Added poll since the topic came up anew due to introdution of tags.

[Dullstar]

I would generally expect all the results to be shown, whether this be done with scrolling, pages, etc. If a search returns a ton of results, it should be my choice whether I want to try narrowing the search or browsing through the results, and I would generally expect narrowing the search to return a subset of the results given with the unnarrowed search, which would not be the case if the search *doesn't* show all the results.

[Simon]

it should be my choice whether I want to try narrowing the search or browsing through the results

This is a key argument, thanks.

I'll remove the cap that cuts results beyond the first 18 results (what happens to fit on one page). The search will retain its other problems, and I'll get back to them next year.

I tend to use the level search as a quickjump, not to find information. I type until it's narrowed to one result, then hit enter.

-- Simon